-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to collect the DNS names from a certificate (finish work from #91 ) #103
base: main
Are you sure you want to change the base?
Conversation
the travis build failed with |
(rebased on master) |
rebased again, all tests pass. @briansmith any ideas if this could be merged? |
@briansmith you mentioned at RustConf that we might be able to merge this? WDYT? |
@briansmith any news on this? |
ping @briansmith ? |
@briansmith is there anything blocking this? |
@briansmith up |
@briansmith is there anything blocking this PR from being merged? I could rebase it over #125 if needed. |
Note: I renamed the "master" branch to "main". Sorry for the inconvenience. This PR has had its base branch updated to "main" but you'll need to deal with the change in your local repo yourself. |
5cb21dd
to
701f123
Compare
@briansmith it's rebased over main, let me know if you need any changes |
6901f07
to
2534131
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 73.56% 76.45% +2.89%
==========================================
Files 14 14
Lines 1362 1525 +163
==========================================
+ Hits 1002 1166 +164
+ Misses 360 359 -1 ☔ View full report in Codecov by Sentry. |
recognize wildcard names
@briansmith all CI checks pass, it should be good to go now |
Any chance of this getting merged? |
Since this repository is not maintained anymore, the main one seems to now be the fork at https://github.com/rustls/webpki. In case you want to follow (or upvote it 🙄), this PR has been ported over to: rustls/webpki#6 (as far as I'm concerned I'm still blocked on it since 2020) |
it's time we get this done :)
In this PR:
untrusted
dependency to the alpha crate like ring doesWildcardDNSName
,WildcardDNSNameRef
, and theGeneralDNSNameRef
enumc*.netflix.com
name, to a certificate with*.netflix.com
, since the name validation function is a bit more strictcc @seanmonstar