Replace 0 by PendingIntent.FLAG_IMMUTABLE for Android>12 comptatibility #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we add an id for autosend and callback? |
thaikhuong62000
pushed a commit
to thaikhuong62000/react-native-get-sms-android
that referenced
this pull request
Jan 27, 2024
|
This should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the requirement of specifying either
FLAG_IMMUTABLEorFLAG_MUTABLEwhen creatingPendingIntentinstances on Android 12 (API level 31) and higher, as per Android 12 behavior changes.I edited the source code to replace
0byFLAG_IMMUTABLEwhen creating new instances ofPendingIntent. In our case, we don't need thePendingIntentto be mutable. That's why I usedFLAG_IMMUTABLE.Thanks to those changes, the library can be used again on latest versions of Android and we avoid having the following error when using the library's methods :
For more information: check the StackOverflow post explaining the issue and its fix.