Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Metrics prefix #624

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Configurable Metrics prefix #624

wants to merge 2 commits into from

Commits on Apr 30, 2016

  1. Add metricsPrefix field to HikariConfig 

    Adding `metricsPrefix` field to HikariConfig and a default of "pool"
because that's what it is currently. This is work towards brettwooldridge#615

Setting the metricsPrefix by default to the poolname + "pool" so that it
matches what's going on in the CodahaleHealthChecker and it will be
easier to update that and keep the old behavior for other people who
don't need to set a custom prefix on there metrics.
    @EdgeCaseBerg
    EdgeCaseBerg committed Apr 30, 2016
    Configuration menu
    Copy the full SHA
    92f1910 View commit details
    Browse the repository at this point in the history

  2. Use metricsPrefix rather than poolname + "pool" 

    Updated metrics related classes to use the metricsPrefix from
HikariConfig rather than a combination of the poolname (from config)
plus the hard coded word "pool". This gives more control to users who
need to set the prefixes of their metrics to something specific such as
the person who raised brettwooldridge#615
    @EdgeCaseBerg
    EdgeCaseBerg committed Apr 30, 2016
    Configuration menu
    Copy the full SHA
    11055d1 View commit details
    Browse the repository at this point in the history