Fixing initializationFailTimeout.

[gierlachg]

An attempt to fix initializationFailTimeout which does not work since 3.3.0 after this change.

[brettwooldridge]

@gierlachg What specific behavior was broken by that change?

[gierlachg]

Well, the functionality behind initializationFailTimeout. As I understand if you start your application and the DB is not there Hikari should try to establish an initial connection (before giving up) for up to initializationFailTimeout millis. In current version it just throws after first failure.

[runenielsen]

@brettwooldridge

We are experiencing the same problem (that the pool fails on first exception, even though we have set initializationFailTimeout to a high number).

Any ETA on this fix?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.12%. Comparing base (086bf18) to head (5413b97).
Report is 246 commits behind head on dev.

Files with missing lines	Patch %	Lines
...c/main/java/com/zaxxer/hikari/pool/HikariPool.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1401      +/-   ##
============================================
+ Coverage     74.92%   75.12%   +0.20%     
- Complexity      547      548       +1     
============================================
  Files            24       24              
  Lines          1934     1930       -4     
  Branches        261      258       -3     
============================================
+ Hits           1449     1450       +1     
+ Misses          341      337       -4     
+ Partials        144      143       -1     

Files with missing lines	Coverage Δ
...c/main/java/com/zaxxer/hikari/pool/HikariPool.java	80.86% <0.00%> (+1.86%)	⬆️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086bf18...5413b97. Read the comment docs.