Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message about failed setLoginTimeout by showing exception type #1343

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

turbanoff
Copy link

Current message about failing setLoginTimeout can be confusing.
For example when using Spring AbstractDataSource - message in logs will looks like this:

Failed to set login timeout for data source. (setLoginTimeout)

From this message it's very hard to understand what was cause of failing method.
I propose to replace e.getMessage() with e.toString() because toString will print exception class name too. And log will look like this:

Failed to set login timeout for data source. (java.lang.UnsupportedOperationException: setLoginTimeout)

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #1343 into dev will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev    #1343      +/-   ##
===========================================
- Coverage     74.7%   74.65%   -0.06%     
+ Complexity     546      545       -1     
===========================================
  Files           23       23              
  Lines         1929     1929              
  Branches       263      263              
===========================================
- Hits          1441     1440       -1     
  Misses         345      345              
- Partials       143      144       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/zaxxer/hikari/pool/PoolBase.java 70.67% <0%> (-0.38%) 54 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa25c3...cc8a57e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant