Change styles on "Read more" button on RFC card #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style changes of the "Read more" button on RFC card:
Light theme
Dark theme
It has a nice hover effect, which is not visible in the screenshot.
This PR is related to #391 issue where @theofidry mentioned that:
As a solution, I think this small change will make it easier to go to an RFC page. Make the whole card as a link is not really possible because we'll need to remove all the links from the inside of the card, since in HTML, you can't have a link inside a link. There is a workaround using JavaScript and click event and
window.location.href = 'some link', but I don't think I want to do that.