Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User feedback #391

Open
theofidry opened this issue Nov 10, 2023 · 9 comments
Open

User feedback #391

theofidry opened this issue Nov 10, 2023 · 9 comments
Assignees
Labels
feedback wanted Issues and PRs which require help of others ux/ui Issues and PRs related to UX/UI design

Comments

@theofidry
Copy link

This is just some feedback after creating an account and checking a few RFCs:

  • I feel the GitHub contribute icon should be on the top right bar besides the footer. Highly subjective, maybe I'm just too use to that (maybe mostly come from the era of where you had a github ribbon on the top right) or some mkdocs templates.
  • When checking another RFCs, currently you see the small box with "Read more" and need to click on the "Read more" link to get there. Maybe the whole thumbnail could be a link instead?
  • When voting I felt it wasn't quite intuitive that you had to click on the bar and then the submit form. Maybe:
    • when click on the "Yes" or "No" button counts, you could be redirect to the submit form
    • it feels confusing that you have to click on the bar to cast your vote, or at least it's not obvious that you get the form bellow to vote on. Part of the confusion, I think, is that the form opens but there is no scroll down so if the bar is on the bottom part of the screen, you may not see the form extending.
    • Maybe this whole part could be resolved by having a "vote" button that opens a new dedicated form (in a new page)?

Sorry if it's a bit disorganized, feel free to just take the bits that interests you or just close the PR, I just wanted to give some raw feedback in case you find it useful.

I otherwise really like the website :)

@SerhiiCho
Copy link
Collaborator

  • When checking another RFCs, currently you see the small box with "Read more" and need to click on the "Read more" link to get there. Maybe the whole thumbnail could be a link instead?

That what we had before, some people prefer link for some reason. I can change it back, I liked it more. We'll see

when click on the "Yes" or "No" button counts, you could be redirect to the submit form

Totally agree on that one!

the form opens but there is no scroll down so if the bar is on the bottom part of the screen, you may not see the form extending.

Also, a great point!

Maybe this whole part could be resolved by having a "vote" button that opens a new dedicated form (in a new page)?

I don't know about this one. Many people (including me) like the voting var on the page, it looks nice. But I get your point, it would have been nice to make it more clear.

Thank you, @theofidry, for these tips, I'll definitely consider your suggestions. You are a huge help 👍🏻 We'll keep this issue open

@SerhiiCho SerhiiCho self-assigned this Nov 10, 2023
@SerhiiCho SerhiiCho added the ux/ui Issues and PRs related to UX/UI design label Nov 10, 2023
@theofidry
Copy link
Author

Many people (including me) like the voting var on the page, it looks nice

Just to clarify: I do love the bar as well, it looks great and its a nice indicator, I just don't find it very intuitive as a "vote action".

@SerhiiCho
Copy link
Collaborator

I'm thinking to add a feature discovery popover like this to make it more clear about how to vote:

image
image

It basically shows up only once, and after you click "Got it!" button, it will not bother anymore.

@theofidry
Copy link
Author

If the intent is to keep the current design definitely. But as stated, I questioned that feature [using the vote bar as an action – the bar itself is cool] because it does not feel intuitive (to the point where a help message is welcomed).

That said it also has the benefit of requiring less efforts.

@SerhiiCho
Copy link
Collaborator

Here is another solution, adding 2 buttons like you suggested.

image

I'm not 100% sure about these styles, might think of something else. Maybe placing them above the bar or something.

@theofidry
Copy link
Author

Oh looks awesome!

Maybe I would also add a vote button next to in-between "no" and "edit"? In the current screenshot this would feel a bit superfluous but when the RFC is much longer, could help to jump to that section? But then again maybe you don't want people to "skip"... So actually not sure about this

@SerhiiCho SerhiiCho added the feedback wanted Issues and PRs which require help of others label Nov 14, 2023
@SerhiiCho
Copy link
Collaborator

SerhiiCho commented Nov 20, 2023

Hey @vsergiu93, @MohammadAlhallaq, @Plytas, @joshbonnick, and @brendt. Can someone provide feedback? What are your thoughts on adding 2 buttons for voting? If yes, where should they be placed? If no, how do we make the voting more intuitive? Your opinion is significant guys. Here are a couple of options

image image image

@SerhiiCho
Copy link
Collaborator

Having gray buttons does look better IMO, but it's just my cup of tea

image

@vsergiu93
Copy link
Contributor

Hey @SerhiiCho, honestly to me all of the options look good, but if I have to pick one I would pick this one:
image
In any case nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Issues and PRs which require help of others ux/ui Issues and PRs related to UX/UI design
Projects
None yet
Development

No branches or pull requests

3 participants