Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Botocore library #971

Closed
wants to merge 12 commits into from
Closed

Botocore library #971

wants to merge 12 commits into from

Conversation

endgame
Copy link
Collaborator

@endgame endgame commented Jan 6, 2024

As part of #872, this PR adds a library to parse botocore service-2.json, waiters-2.json and paginators-1.json files. They use a hand-written parser based on the new Data.Aeson.Decoding.Tokens provided by recent versions of aeson.

Because the generator currently smooshes the aeson Values of these three together before attempting parsing, this PR also includes separate parsers for Service, Waiters, and Paginators, so that we can load each type of file individually and then marshal them into the types currently used by gen.

Future work:

  • Applying annexes
  • Plumbing this into gen

@endgame endgame requested a review from brendanhay January 6, 2024 02:21
@endgame
Copy link
Collaborator Author

endgame commented Jun 4, 2024

After discussions with Brendan and also internally, this code has been published at https://github.com/bellroy/hs-botocore .

This prevents the copyright situation of files in this repo from becoming too complicated, and ensures that Bellroy gets appropriate credit for the work it paid for in developing this library. It also means that should the JSON parser become interesting enough for further development, it's clearly available under BSD3.

Brendan has been invited as a maintainer to ensure that he still has control of his project.

@endgame endgame closed this Jun 4, 2024
@endgame endgame deleted the botocore-library branch June 4, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant