Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- make cachestat compatible with older bash versions #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sinnohd
Copy link

@Sinnohd Sinnohd commented Sep 8, 2015

Older versions of bash are not supporting the printf %(FORMAT)T format. I quickly added a date based subtraction.

If someone has time, he can also implement a version check and use the printf with newer bash versions (less overhead) and the date part with older.

@brendangregg
Copy link
Owner

Thank you, but no. I object to performance tools that themselves waste performance without a really good reason. This change would do an extra fork/exec for every interval. I understand the reason, but I don't think it's a really good one. I'd also not be that interested in code that checked the bash version and then made an appropriate choice -- obfuscating the script, without a really good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants