Reworked Payment Status screens #254
Merged
+990
−1,327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
force-pushed
the
payment_status_screens
branch
2 times, most recently
from
3ab1857
to
9ae0b8d
Compare
erdemyerebasmaz
force-pushed
the
send_payment_ui_feedback
branch
from
f827336
to
6b592a5
Compare
erdemyerebasmaz
force-pushed
the
payment_status_screens
branch
3 times, most recently
from
98b5673
to
b4003cb
Compare
erdemyerebasmaz
force-pushed
the
send_payment_ui_feedback
branch
from
7e19b4f
to
c25f25d
Compare
erdemyerebasmaz
force-pushed
the
payment_status_screens
branch
from
aac1d05
to
31459c8
Compare
erdemyerebasmaz
force-pushed
the
send_payment_ui_feedback
branch
from
c25f25d
to
7f3cd3a
Compare
erdemyerebasmaz
force-pushed
the
payment_status_screens
branch
from
64647e4
to
b68b4e1
Compare
* Remove SuccessActionDialog
Track new payments after a delay on LN Address page.
* Remove simple_animations plugin
- Fix Dividers - Show warning icon if QR can't be generated - Show warning color if redeeming funds fail
- LNURL Payment Description is shown on bottom on confirmation page - Fee amount color - Addressed some padding issues
Instead of hiding it
- Increased the padding between "Use All Funds" & "Balance" text. - "Use All Funds" text is no longer bold - Balance text's font size is increased.
Blue spinner is shown until the QR image data is ready, and the QR image is shown immediately once it's data becomes available.
with a minimum padding of 32dp between them.
using description box's style and (optional) removed from it's label. Do not display it on confirmation page if comment is left empty.
erdemyerebasmaz
force-pushed
the
payment_status_screens
branch
from
b68b4e1
to
f5e6873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.