Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for paying BOLT12 offers #251

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add support for paying BOLT12 offers #251

merged 2 commits into from
Dec 3, 2024

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Nov 20, 2024 •
edited
Loading

Closes #248

The PR is in draft because UI isn't fully ready yet but it has basic support for paying BOLT12 offers.

It uses elements from both LNInvoice & LNURL Payment pages but is not optimized and following fields are currently not being utilized:

List<String> chains;
Amount? minAmount; # Amount.Currency variant isn't handled
BigInt? absoluteExpiry;
String? issuer;
String? signingPubkey;
List<LnOfferBlindedPath> paths;

@erdemyerebasmaz erdemyerebasmaz marked this pull request as ready for review November 22, 2024 08:02
ok300
ok300 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@ok300 ok300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@erdemyerebasmaz erdemyerebasmaz merged commit 7ab710e into main Dec 3, 2024
1 check passed
@erdemyerebasmaz erdemyerebasmaz deleted the bolt12_integration branch December 3, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ok300 ok300 ok300 approved these changes

@dangeross dangeross Awaiting requested review from dangeross

@roeierez roeierez Awaiting requested review from roeierez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for paying BOLT12 offers
2 participants
@erdemyerebasmaz @ok300