Persist swapper fees for swaps #586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores the swapper service fees for each swap type.
The service fee is reflected in the
Paymentinswapper_fees_sat. ThePaymentalready contains the total fees infees_sat, so from these two values a user can find the total swap network fees (total - service fees).For chain swaps, this PR persists the service feerate instead of the service fee. In addition it also stores the server fees, which are a chain-swap-specific type of network fee (lockup tx fees paid by the server when locking up funds for the destination chain). These two new chain swap fields will later be used to validate the fees in Amountless Receive Chain Swaps.