Merge pull request #1513 from ArielCalisaya/dev-path-4

Update event names for feedback actions in CodeReview compo…
breatheco-de · Jun 21, 2024 · 366c1da · 366c1da
2 parents 4494e25 + 2535ba8
commit 366c1da
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/src/common/components/ReviewModal/CodeReview.jsx b/src/common/components/ReviewModal/CodeReview.jsx
@@ -233,7 +233,7 @@ function CodeReview({ isExternal, onClose, disableRate, isStudent, handleResetFl
     };
     reportDatalayer({
       dataLayer: {
-        event: 'feedback_reaction',
+        event: 'feedback_student_reaction',
         feedback_id: revisionContent?.id,
         reaction: reviewRateData?.status,
         reaction_comment: type === 'skip' ? '' : reviewRateData?.comment,

diff --git a/src/common/components/ReviewModal/index.jsx b/src/common/components/ReviewModal/index.jsx
@@ -148,7 +148,7 @@ function ReviewModal({ isExternal, externalFiles, isOpen, isStudent, externalDat
   const rejectOrApprove = (status) => {
     reportDatalayer({
       dataLayer: {
-        event: 'feedback_action',
+        event: 'feedback_reject_or_approve',
         action_type: status,
         task_id: currentTask?.id,
         user_id: user.id,

diff --git a/src/common/utils/iconDict.json b/src/common/utils/iconDict.json
diff --git a/src/js_modules/profile/Subscriptions/ButtonHandler.jsx b/src/js_modules/profile/Subscriptions/ButtonHandler.jsx
@@ -14,7 +14,7 @@ function ButtonHandler({
   const [isLoading, setIsLoading] = useState(false);
   const isFullyPaid = subscription?.status?.toLowerCase() === 'fully_paid';
   const planSlug = subscription?.plans?.[0]?.slug;
-  const isPlanFinancingExpired = subscription.type === 'plan_financing' && subscription.valid_until < new Date().toISOString();
+  const isPlanFinancingExpired = subscription?.type === 'plan_financing' && subscription?.valid_until < new Date().toISOString();
 
   const {
     getPlanOffer,