[AlertCenter]: fixes 'undefined' title when no title provided #933

AlanBreck · 2024-12-09T19:11:00Z

Resolves #932

src/components/alert/alert.stories.svelte

github-actions · 2024-12-09T19:13:56Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://933.pr.nala.bravesoftware.com/
✅ Commit preview: https://933.pr.nala.bravesoftware.com/commit-db17cfc4036057ceb351841c32a908baaa045bb8/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-12-09 19:12:21.986524179 +0000
+++ ./tokens/css/variables-android.css	2024-12-09 19:11:43.006006983 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:43 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-12-09 19:12:22.518531255 +0000
+++ ./tokens/css/variables-browser.css	2024-12-09 19:11:42.982006667 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-12-09 19:12:22.802535031 +0000
+++ ./tokens/css/variables-ios.css	2024-12-09 19:11:43.022007194 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:43 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-12-09 19:12:23.062538487 +0000
+++ ./tokens/css/variables-marketing.css	2024-12-09 19:11:43.042007458 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:43 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-12-09 19:12:23.322541944 +0000
+++ ./tokens/css/variables-news.css	2024-12-09 19:11:43.070007828 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:43 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-12-09 19:12:23.558545084 +0000
+++ ./tokens/css/variables-newtab.css	2024-12-09 19:11:43.078007934 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:43 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-12-09 19:12:23.794548221 +0000
+++ ./tokens/css/variables-search.css	2024-12-09 19:11:43.062007723 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:43 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-12-09 19:12:24.038551468 +0000
+++ ./tokens/css/variables-web3.css	2024-12-09 19:11:43.082007986 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:43 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-12-09 19:12:24.438556785 +0000
+++ ./tokens/css/variables.css	2024-12-09 19:11:42.842004820 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Dec 06 2024 01:58:05 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 19:11:42 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

fallaciousreasoning · 2024-12-09T20:41:57Z

src/components/alert/alertCenter.svelte

@@ -114,7 +114,7 @@
    >
      <svelte:component this={alert.component || Alert} {...alert} hasActions={alert.actions.length > 0} hasContentAfter={alert.canDismiss} isToast>
        <div slot="title">
-          {alert.title}
+          {alert.title ?? ""}


Wow, super weird it renders undefined here instead of nothing 😨

github-actions · 2024-12-09T21:35:18Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://933.pr.nala.bravesoftware.com/
✅ Commit preview: https://933.pr.nala.bravesoftware.com/commit-8cc827d3552b6dba26a549101b3ca4cb73a83bfe/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-12-09 21:33:41.716088353 +0000
+++ ./tokens/css/variables-android.css	2024-12-09 21:33:01.227183014 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-12-09 21:33:41.996094132 +0000
+++ ./tokens/css/variables-browser.css	2024-12-09 21:33:01.211182631 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-12-09 21:33:42.252099417 +0000
+++ ./tokens/css/variables-ios.css	2024-12-09 21:33:01.243183396 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-12-09 21:33:42.532105195 +0000
+++ ./tokens/css/variables-marketing.css	2024-12-09 21:33:01.271184065 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-12-09 21:33:42.776110237 +0000
+++ ./tokens/css/variables-news.css	2024-12-09 21:33:01.299184734 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-12-09 21:33:43.020115274 +0000
+++ ./tokens/css/variables-newtab.css	2024-12-09 21:33:01.307184926 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-12-09 21:33:43.412123856 +0000
+++ ./tokens/css/variables-search.css	2024-12-09 21:33:01.291184543 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-12-09 21:33:43.652129337 +0000
+++ ./tokens/css/variables-web3.css	2024-12-09 21:33:01.315185117 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-12-09 21:33:43.892134816 +0000
+++ ./tokens/css/variables.css	2024-12-09 21:33:01.071179286 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:30:14 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:33:01 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

AlanBreck requested review from fallaciousreasoning and petemill as code owners December 9, 2024 19:11

AlanBreck commented Dec 9, 2024

View reviewed changes

src/components/alert/alert.stories.svelte Show resolved Hide resolved

fallaciousreasoning reviewed Dec 9, 2024

View reviewed changes

fallaciousreasoning approved these changes Dec 9, 2024

View reviewed changes

[AlertCenter]: fixes 'undefined' title when no title provided

8cc827d

AlanBreck force-pushed the alert-center-fix branch from db17cfc to 8cc827d Compare December 9, 2024 21:32

AlanBreck merged commit abda95f into main Dec 9, 2024
6 checks passed

AlanBreck deleted the alert-center-fix branch December 9, 2024 21:35

petemill mentioned this pull request Dec 12, 2024

Update leo dependency brave/brave-core#26995

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AlertCenter]: fixes 'undefined' title when no title provided #933

[AlertCenter]: fixes 'undefined' title when no title provided #933

AlanBreck commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024

fallaciousreasoning Dec 9, 2024

github-actions bot commented Dec 9, 2024

[AlertCenter]: fixes 'undefined' title when no title provided #933

[AlertCenter]: fixes 'undefined' title when no title provided #933

Conversation

AlanBreck commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024

fallaciousreasoning Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024

AlanBreck commented Dec 9, 2024 •

edited

Loading