css variables: additional variables for colors omitting the rgb() function call #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction call So that colors may be used with custom opacity at the point of use. The new variables have the suffix "-rgb"
petemill
commented
Aug 8, 2022
| const rgbEnd = ')' | ||
| if (token.value && token.value.startsWith(rgbStart) && token.value.endsWith(rgbEnd)) { | ||
| const newToken = { ...token } | ||
| newToken.value = token.value.slice(rgbStart.length).slice(0, rgbEnd.length * -1) |
There was a problem hiding this comment.
Not sure why I've used 2 slices here!
|
Evaluate these as part of consideration for including this:
If this is a blocker for immediate consumption then we can merge and iron out details later. As part of evaluation include react and styled-components and minimal tailwind that can use theme function in the example webpack app and show Douglas / wallet team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that colors may be used with custom opacity at the point of use. The new variables have the suffix "-rgb"