Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix brave-browser #36266: Buy/Send/Swap button is not opening in Asset Details Screen. #8772

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Feb 26, 2024

Ref:
brave/brave-core#22229

Summary of Changes

Copy over the fix from brave-core to brave-ios for 1.62.x hotfix.

This pull request fixes #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Go to an asset details that no wallet account has balance of it
click Buy/Send/Swap button
button should open correct screen for users to buy/send/swap

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu self-assigned this Feb 26, 2024
@nuo-xu nuo-xu requested a review from a team as a code owner February 26, 2024 18:49
@nuo-xu nuo-xu merged commit c2d0069 into release Feb 26, 2024
5 of 6 checks passed
@nuo-xu nuo-xu deleted the bugfix/buy-send-swap-asset-details branch February 26, 2024 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants