Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bottom of vpn icon of vpn card was clipped #26765

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 27, 2024

fix brave/brave-browser#42543

Wrong width/height was set. It should be 64px.

Screenshot 2024-11-27 114539

Screen.Recording.2024-11-27.114604.mp4

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

fix brave/brave-browser#42543

Wrong width/height was set. It should be 64px.
@simonhong simonhong self-assigned this Nov 27, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 27, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong simonhong merged commit 4339e21 into master Nov 27, 2024
18 checks passed
@simonhong simonhong deleted the fix_vpn_icon_size_vpn_card branch November 27, 2024 23:17
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 27, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.58

simonhong added a commit that referenced this pull request Nov 28, 2024
Fixed bottom of vpn icon of vpn card was clipped
simonhong added a commit that referenced this pull request Nov 28, 2024
Fixed bottom of vpn icon of vpn card was clipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom of VPN icon of vpn card is clipped
3 participants