-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(privacy): Generic cosmetic filter list rules are not applied on some sites on iOS #26729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHeaps
added
CI/skip-android
Do not run CI builds for Android
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
CI/skip-macos-arm64
Do not run CI builds for macOS arm64
labels
Nov 25, 2024
stoletheminerals
approved these changes
Nov 25, 2024
Brandon-T
approved these changes
Nov 25, 2024
…ectly sent from javascript to native.
StephenHeaps
force-pushed
the
privacy/fix-ios-generic-cosmetic-filters
branch
from
November 25, 2024 19:46
9e50a95
to
beea26e
Compare
brave-builds
added a commit
that referenced
this pull request
Nov 25, 2024
brave-builds
added a commit
that referenced
this pull request
Nov 25, 2024
Released in v1.75.50 |
Verification PASSED on
Using the STR/Cases outlined via #26729 (comment), ensured that the https://laurentferrier.ch/products/classic-auto-sandstone?variant=44866903605410ScreenRecording_11-26-2024.16-06-26_1.MP4https://www.chefs-edge.com/collections/whetstones/products/shapton-rockstar-whetstone-1000-gritScreenRecording_11-26-2024.16-07-44_1.MP4https://goldammer.me/collections/allScreenRecording_11-26-2024.16-08-47_1.MP4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-android
Do not run CI builds for Android
CI/skip-macos-arm64
Do not run CI builds for macOS arm64
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id
value was being passed from javascript to Swift to check against the AdblockEngine to determine if it should be hidden. This invalid id was causing the message to fail and never be sent to Swift / native, so it was never checked against the AdblockEngine.getAttribute
, and added a safety string check.Resolves brave/brave-browser#42471
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: