Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run compare-chromium-versions in PRs from forks #26701

Merged

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Nov 22, 2024

Resolves https://bravesoftware.slack.com/archives/C7VLGSR55/p1729065734149969

The check always fails in PRs from forks due to

GraphQL: Resource not accessible by integration (removeLabelsFromLabelable)
Error: Process completed with exit code 1.

which is expected. The failure is misleading to developers and reviewers. This PR sorts that out.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik added CI/skip Do not run CI builds (except noplatform) CI/skip-teamcity Do not run builds in TeamCity labels Nov 22, 2024
@wknapik wknapik self-assigned this Nov 22, 2024
@wknapik wknapik marked this pull request as ready for review November 22, 2024 18:05
@wknapik wknapik requested a review from a team as a code owner November 22, 2024 18:05
@wknapik wknapik enabled auto-merge (squash) November 22, 2024 18:05
@wknapik wknapik merged commit a0492bd into master Nov 22, 2024
18 checks passed
@wknapik wknapik deleted the wknapik-do-not-compare-chromium-versions-in-prs-from-forks branch November 22, 2024 18:06
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 22, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) CI/skip-teamcity Do not run builds in TeamCity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants