AI Chat fullpage UI notices and polish #26678

petemill · 2024-11-21T03:27:17Z

Shows a notice that the full-page feature is now available
Shows a notice when the conversation list is empty
Shows a notice when storage pref is disabled and offers an action to enable
Fixes FullPage showing as SidePanel mode when restoring browser state after startup
Optimizes loading by fetching initial properties as soon as JS is ready and not after first react render (seems to save up to 60ms on my machine, but that's in dev)
Shows a full-page loading indicator and other minor page-load visual polish
Fix "new conversation" button showing on collapsed navigation when conversation is already new
AI Chat conversation items get their intended max-width and line up with input box

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

…nd notices

…minor polish)

brave-builds · 2024-11-21T04:31:34Z

A Storybook has been deployed to preview UI for the latest push

…versation is new

petemill · 2024-11-22T17:20:10Z

Depends on brave/leo#912

diracdeltas · 2024-11-22T19:25:21Z

does https://github.com/brave/reviews/issues/1703#issuecomment-2260662872 need to be addressed now or is this still all behind a feature flag?

thypon

security gtg

petemill · 2024-11-22T20:45:18Z

@diracdeltas I'm not sure if this notice is enough to cover all that info, but yes it's still behind a feature flag and I'll ask if we've done enough when asking to remove that flag.

ShivanKaul · 2024-11-22T21:02:04Z

components/ai_chat/core/browser/ai_chat_service.cc

+  profile_prefs_->SetBoolean(prefs::kStorageEnabled, true);
+}
+
+void AIChatService::DismissStorageNotice() {


We reach this if the user presses X on the top-right of the Conversation history popup in Leo, right? We also need an explicit "Don't do this" or "No thanks" button on that popup, otherwise this seems like a consent dark pattern. The language on that popup right now makes me think that the X will actually just dismiss the popup without actually opting me out of this feature change.

@ShivanKaul The storage notice is dismissed either by clicking the X or after it's been viewed once for a few seconds.
As far as I understand, the opinion was that we did not need to present the opt-out preference inline as it's not going to affect any previous actions the user does, only the future actions. And that we don't need explicit opt-in permission from the user to store submitted conversations on their own computer (encrypted) for the AI chat feature. This seems more of a notice about the new feature. @mattmcalister

ShivanKaul · 2024-11-22T21:04:58Z

components/resources/ai_chat_ui_strings.grdp

+    Conversation history
+  </message>
+  <message name="IDS_CHAT_UI_NOTICE_CONVERSATION_HISTORY_BODY" desc="Main text for the notice about conversation history">
+    Leo will now remember your previous conversations so you can go back to them. They are stored privately on your device, and you can delete them any time.


Suggested change

Leo will now remember your previous conversations so you can go back to them. They are stored privately on your device, and you can delete them any time.

Leo will now remember your conversations so you can go back to them. They are stored encrypted on your device, and you can delete them any time.

ShivanKaul · 2024-11-22T21:06:37Z

components/ai_chat/resources/page/components/notices/notice_conversation_storage.tsx

+        <p>{getLocale('noticeConversationHistoryBody')}</p>
+        <p>
+          <a
+            href='#'


Let's make sure the help page for this feature gets reviewed before shipping.

this isn't the url it points to, it's the current Leo help page

mkarolin · 2024-11-22T21:07:27Z

components/resources/ai_chat_ui_strings.grdp

+    Conversation history
+  </message>
+  <message name="IDS_CHAT_UI_NOTICE_CONVERSATION_HISTORY_BODY" desc="Main text for the notice about conversation history">
+    Leo will now remember your previous conversations so you can go back to them. They are stored privately on your device, and you can delete them any time.


Maybe don't need the word previous here?

great minds @mkarolin

ShivanKaul · 2024-11-22T21:09:58Z

components/resources/ai_chat_ui_strings.grdp

+    History is disabled
+  </message>
+  <message name="IDS_CHAT_UI_NOTICE_CONVERSATION_HISTORY_DISABLED_PREF" desc="Main text for a notice that the conversation history preference is disabled">
+    In order to view and search your previous conversations with Leo, you need to enable conversation history.


Similarly here, I don't think we need the word "previous". Not blocking.

I'd argue previous in this case is necessary (although I'll remove the "and search" part because we don't have that). Feels a bit strange to be viewing a conversation (a non-stored one) with a notice saying "In order to view your conversations with Leo, you need to...".

ShivanKaul · 2024-11-22T21:12:58Z

It's hard to review this from a privacy/consent perspective just from the screenshots. I suggested changes for the text, but it's not clear to me if the intention is to block users from going back to the old behaviour on sidebar Leo (i.e. ephemeral-only chats). Does the "History is disabled" prompt block users from interacting with Leo?

…ith input box

petemill · 2024-11-23T01:27:39Z

Does the "History is disabled" prompt block users from interacting with Leo?

@ShivanKaul this prompt shows when the user has disabled the AI Chat history storage preference (which is enabled by default for all users). It does not block anything. It informs the user that conversations are ephemeral and won't show up in a list once the conversation is closed.

petemill · 2024-11-23T01:38:36Z

It's hard to review this from a privacy/consent perspective just from the screenshots

@ShivanKaul In that case, I suggest we don't block this PR so that reviewers can easily use the feature end-to-end in nightly. Although if there are obvious required changes to these pieces then we should do them here. This also doesn't contain any initial opt-in changes that may be required.

Instead we can block feature flag removal unril privacy review is successful.

petemill added 4 commits November 20, 2024 09:24

AIChat storage notice and more reliable initial state of agreements a…

1ec4bd2

…nd notices

More reliable determination if standalone or not

2d7b3dd

Optimize loading by putting global variable fetching in non-react code

61632dc

conversation-list empty notice and whole page loading indicator (and …

6639cd0

…minor polish)

petemill requested a review from fallaciousreasoning November 21, 2024 03:27

petemill self-assigned this Nov 21, 2024

petemill requested a review from a team as a code owner November 21, 2024 03:27

github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build puLL-Merge labels Nov 21, 2024

fix ios

75857a4

petemill added 3 commits November 22, 2024 09:11

Notice for enabling storage pref

1b7b286

temp nala bump

198d74f

Full Page collapsed nav shouldn't show new conversation button if con…

a4af209

…versation is new

petemill requested review from a team as code owners November 22, 2024 17:15

github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Nov 22, 2024

thypon approved these changes Nov 22, 2024

View reviewed changes

diracdeltas requested a review from PrivacyMatters November 22, 2024 20:47

ShivanKaul reviewed Nov 22, 2024

View reviewed changes

mkarolin reviewed Nov 22, 2024

View reviewed changes

ShivanKaul reviewed Nov 22, 2024

View reviewed changes

petemill added 2 commits November 22, 2024 17:22

notice polish

ff632b0

AI Chat conversation items get their intended max-width and line up w…

f90ad57

…ith input box

petemill changed the title ~~AI Chat fullpage notices~~ AI Chat fullpage notices and polish Nov 23, 2024

petemill changed the title ~~AI Chat fullpage notices and polish~~ AI Chat fullpage UI notices and polish Nov 23, 2024

adjust strings based on review

06ee62b

brave deleted a comment from github-actions bot Nov 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AI Chat fullpage UI notices and polish #26678

AI Chat fullpage UI notices and polish #26678

petemill commented Nov 21, 2024 •

edited

Loading

brave-builds commented Nov 21, 2024

petemill commented Nov 22, 2024

diracdeltas commented Nov 22, 2024

thypon left a comment

petemill commented Nov 22, 2024

ShivanKaul Nov 22, 2024

petemill Nov 23, 2024

ShivanKaul Nov 22, 2024

petemill Nov 23, 2024

ShivanKaul Nov 22, 2024

petemill Nov 23, 2024

mkarolin Nov 22, 2024

ShivanKaul Nov 22, 2024

petemill Nov 23, 2024

ShivanKaul Nov 22, 2024

petemill Nov 23, 2024

ShivanKaul commented Nov 22, 2024

petemill commented Nov 23, 2024

petemill commented Nov 23, 2024

	Leo will now remember your previous conversations so you can go back to them. They are stored privately on your device, and you can delete them any time.
	Leo will now remember your conversations so you can go back to them. They are stored encrypted on your device, and you can delete them any time.

AI Chat fullpage UI notices and polish #26678

Are you sure you want to change the base?

AI Chat fullpage UI notices and polish #26678

Conversation

petemill commented Nov 21, 2024 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented Nov 21, 2024

petemill commented Nov 22, 2024

diracdeltas commented Nov 22, 2024

thypon left a comment

Choose a reason for hiding this comment

petemill commented Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShivanKaul commented Nov 22, 2024

petemill commented Nov 23, 2024

petemill commented Nov 23, 2024

petemill commented Nov 21, 2024 •

edited

Loading