Improve NTP Sponsored Images logs #26636
Merged
+43
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
reviewed
Nov 19, 2024
Comment on lines
76
to
83
| VLOG(6) << "Cannot find valid component manifest file in: " | ||
| << installed_dir; | ||
| return contents; | ||
| } | ||
|
|
||
| bool success = base::ReadFileToString(json_path, &contents); | ||
| if (!success || contents.empty()) { | ||
| DVLOG(2) << __func__ << ": cannot read json file " << json_path; | ||
| VLOG(6) << "Cannot read component manifest file at: " << json_path; |
There was a problem hiding this comment.
The logs seem to generic, can we please mention "NTP Background Images"
There was a problem hiding this comment.
Actually this can be any of:
- NTP Background Images
- NTP Sponsored Images
- NTP Super Referral Images.
There was a problem hiding this comment.
So maybe, Cannot read NTP Images component manifest file at:...
tmancey
reviewed
Nov 19, 2024
components/ntp_background_images/browser/ntp_background_images_service.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Nov 19, 2024
| @@ -204,7 +204,7 @@ void NTPBackgroundImagesService::RegisterSponsoredImagesComponent() { | |||
| } | |||
| sponsored_images_component_id_ = data->component_id.data(); | |||
|
|
|||
| DVLOG(2) << __func__ << ": Start NTP SI component"; | |||
| VLOG(6) << "Register NTP Sposored Images component"; | |||
There was a problem hiding this comment.
We already log the same information in `RegisterBackgroundImagesComponent()
There was a problem hiding this comment.
RegisterBackgroundImagesComponent contains different log:
VLOG(6) << "Register NTP Background Images component";
tmancey
reviewed
Nov 19, 2024
components/ntp_background_images/browser/ntp_background_images_service.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Nov 19, 2024
components/ntp_background_images/browser/ntp_background_images_service.cc
Show resolved
Hide resolved
|
Released in v1.75.36 |
aseren
added a commit
that referenced
this pull request
Nov 20, 2024
Improve NTP Sponsored Images logs
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#42372
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
No manual testing is required.