Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SelectParserRelaxation #26632

Closed

Conversation

atuchin-m
Copy link
Collaborator

Resolves brave/brave-browser#42366

Backports https://issues.chromium.org/issues/379034733

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m self-assigned this Nov 19, 2024
@atuchin-m atuchin-m requested a review from a team as a code owner November 19, 2024 13:16
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin
Copy link
Collaborator

2 upstream browser tests are failing:

 2 tests failed:
     SelectParserRelaxationEnabledPolicyBrowserTest.PolicyIsFollowed/Default (../../chrome/browser/policy/test/select_parser_relaxation_policy_browsertest.cc:59)
     SelectParserRelaxationEnabledPolicyBrowserTest.PolicyIsFollowed/True (../../chrome/browser/policy/test/select_parser_relaxation_policy_browsertest.cc:59)

@atuchin-m
Copy link
Collaborator Author

2 upstream browser tests are failing:

That's weird that chromium doesn't disable the same tests..
If we disable them, we have to revert after.

Maybe it makes more sense to disable the feature via Griffin to address this.

@atuchin-m
Copy link
Collaborator Author

The CL is uplifted to https://chromium-review.googlesource.com/c/chromium/src/+/6023765 => we don’t need to backport it manually.

@atuchin-m atuchin-m closed this Nov 20, 2024
@atuchin-m
Copy link
Collaborator Author

LOL, chromium actually missed these tests had been broken by the original CL: https://chromium-review.googlesource.com/c/chromium/src/+/6034315

@atuchin-m atuchin-m deleted the issues/42366-disable-SelectParserRelaxation branch November 20, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable SelectParserRelaxation in cr131
2 participants