Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings]: Fix missing top paddings (uplift to 1.74.x) #26618

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[Settings]: Fix missing top paddings (uplift to 1.74.x) #26618

merged 1 commit into from
Nov 19, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 18, 2024 •
edited by kjozwiak
Loading

Uplift of #26573
Resolves brave/brave-browser#41929

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 18, 2024 19:19
@brave-builds brave-builds requested a review from a team November 18, 2024 19:19
@brave-builds brave-builds added this to the 1.74.x - Beta milestone Nov 18, 2024
@brave-builds brave-builds self-assigned this Nov 18, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 18, 2024
sasco20

This comment was marked as spam.

Sign in to view

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26573 (comment).

@kjozwiak kjozwiak merged commit 20be4a7 into 1.74.x Nov 19, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr26573_settings-padding_1.74.x branch November 19, 2024 03:49
@brave-builds
Copy link
Collaborator Author

Released in v1.74.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasco20 sasco20 sasco20 left review comments

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @sasco20