Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fallback to default value correctly for optional preferences (uplift to 1.74.x) #26615

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[iOS] Fallback to default value correctly for optional preferences (uplift to 1.74.x) #26615

merged 1 commit into from
Nov 19, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 18, 2024 •
edited by kjozwiak
Loading

Uplift of #26610
Resolves brave/brave-browser#42320

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 18, 2024 18:49
@brave-builds brave-builds requested a review from a team November 18, 2024 18:49
@brave-builds brave-builds added this to the 1.74.x - Beta milestone Nov 18, 2024
@brave-builds brave-builds self-assigned this Nov 18, 2024
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 18, 2024
kjozwiak
kjozwiak approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26610 (comment).

@kjozwiak kjozwiak merged commit 16d5e10 into 1.74.x Nov 19, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr26610_ios-shortcut-button-migration-fix_1.74.x branch November 19, 2024 04:30
@brave-builds
Copy link
Collaborator Author

Released in v1.74.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @kylehickinson