Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): fix swap error validation order #26593

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

onyb
Copy link
Member

@onyb onyb commented Nov 15, 2024

Resolves brave/brave-browser#42256
Resolves brave/brave-browser#42257

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See STR in linked issues

@onyb onyb self-assigned this Nov 15, 2024
@onyb onyb requested review from a team as code owners November 15, 2024 20:20
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Nov 15, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@supermassive supermassive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet core lgtm

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@onyb onyb merged commit 8185cf1 into master Nov 18, 2024
18 checks passed
@onyb onyb deleted the f/wallet/fix-swap-error-validation branch November 18, 2024 16:52
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 18, 2024
brave-builds added a commit that referenced this pull request Nov 18, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.29

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.75.30 Chromium: 131.0.6778.69 (Official Build) nightly (64-bit)
Revision c60b139
OS Linux

brave/brave-browser#42257

  • Verified steps from issue description
  • Verified clicking on Swap from side navigation, resets the view
42257.mp4

brave/brave-browser#42256

  • Verified steps from issue description
  • Verified Squid provider generates quotes for all token pairs
42256.mp4

kjozwiak pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
6 participants