-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes certificate manager branding. #26561
Conversation
ui/webui/resources/cr_components/certificate_manager/brave_overrides/certificate_manager_v2.ts
Outdated
Show resolved
Hide resolved
A Storybook has been deployed to preview UI for the latest push |
5476613
to
a3ad284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % nits
Thanks for doing that @mkarolin - it's much cleaner now 😄
ui/webui/resources/cr_components/certificate_manager/brave_overrides/certificate_manager_v2.ts
Outdated
Show resolved
Hide resolved
ui/webui/resources/cr_components/certificate_manager/brave_overrides/index.ts
Outdated
Show resolved
Hide resolved
Removes br_toolbar from polymer_overriding and imports it only in UIs that need it.
5c41833
to
14403c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string reviewers ++
Released in v1.75.33 |
Verification PASSED on
|
Uplift of #26561 (squashed) to beta
Resolves brave/brave-browser#41938
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: