Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes certificate manager branding. #26561

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 14, 2024

Resolves brave/brave-browser#41938

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Please, verify with STRs in the issue
  • Additionally, please, verify that WebUIs didn't regress in showing Brave toolbar on pages such as brave://settings, brave://history, brave://extensions, and any others that you can think of that show the toolbar.

@mkarolin mkarolin self-assigned this Nov 14, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 14, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin force-pushed the maxk-fix-cert-manager-branding branch from 5476613 to a3ad284 Compare November 14, 2024 22:29
@mkarolin mkarolin marked this pull request as ready for review November 15, 2024 17:29
@mkarolin mkarolin requested review from a team as code owners November 15, 2024 17:29
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nits

Thanks for doing that @mkarolin - it's much cleaner now 😄

@mkarolin mkarolin force-pushed the maxk-fix-cert-manager-branding branch from 5c41833 to 14403c9 Compare November 18, 2024 14:20
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string reviewers ++

@mkarolin mkarolin merged commit 044184f into master Nov 19, 2024
17 checks passed
@mkarolin mkarolin deleted the maxk-fix-cert-manager-branding branch November 19, 2024 15:02
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 19, 2024
brave-builds added a commit that referenced this pull request Nov 19, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.33

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 20, 2024

Verification PASSED on

Brave | 1.75.33 Chromium: 131.0.6778.69 (Official Build) nightly (64-bit)
-- | --
Revision | 023382faa9de31889a4a866e4b1e04614146cb79
OS | Windows 10 Version 22H2 (Build 19045.5131)
Example Example
image image

kjozwiak pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
7 participants