Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI Chat: fix action menu #26555

Merged
merged 1 commit into from
Nov 19, 2024
Merged

AI Chat: fix action menu #26555

merged 1 commit into from
Nov 19, 2024

Conversation

petemill
Copy link
Member

@petemill petemill commented Nov 14, 2024 •
edited
Loading

Resolves brave/brave-browser#42279

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this Nov 14, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 14, 2024
petemill
petemill commented Nov 14, 2024
View reviewed changes
components/ai_chat/resources/page/state/conversation_context.tsx
@@ -125,10 +123,8 @@ export const getFirstValidAction = (actionList: mojom.ActionGroup[]) =>

export function useActionMenu(
filter: string,
getActions: () => Promise<mojom.ActionGroup[]>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't see the advantage of a "getter" param instead vs the data

SergeyZhukovsky
SergeyZhukovsky approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

fallaciousreasoning
fallaciousreasoning approved these changes Nov 14, 2024
View reviewed changes
components/ai_chat/resources/page/state/conversation_context.tsx
@@ -314,8 +310,7 @@ export function ConversationContextProvider(
})
}, [context.conversationUuid, context.faviconCacheKey])

const actionList = useActionMenu(context.inputText, () =>
Promise.resolve(aiChatContext.allActions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very confused about this 😆

@petemill petemill merged commit ad477d2 into master Nov 19, 2024
18 checks passed
@petemill petemill deleted the ai-chat-fix-action-menu branch November 19, 2024 00:05
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 19, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.31

petemill added a commit that referenced this pull request Nov 20, 2024
@petemill
AI Chat: fix action menu (#26555)
0361080 
Resolves brave/brave-browser#41635
Resolves brave/brave-browser#42279
petemill added a commit that referenced this pull request Nov 20, 2024
@petemill
AI Chat: fix action menu (#26555)
5fe6921 
Resolves brave/brave-browser#41635
Resolves brave/brave-browser#42279
This was referenced Nov 20, 2024
Merged
Merged
@hffvld
Copy link
Collaborator

hffvld commented Nov 21, 2024

Verified on Galaxy Z Fold 6 using version(s):

Device/OS: Galaxy Z Fold 6 / q6quew-user 14 UP1A.231005.007 release-keys
Brave build: 1.75.36 
Chromium: 131.0.6778.85 (Official Build) canary (64-bit)

STEPS:

  1. Launch Brave
  2. Open Leo
  3. Tap [/] to open slash tools > Verify
  4. Select Change tone > Academic, for example, and type a query
  5. Wait for the response > Verify

ACTUAL RESULTS:

  • Verified that the slash tools menu can be opened.
  • Verified that the slash tools can be used when sending a query to Leo.
1 2 3 4
1 2 3 4

@hffvld
Copy link
Collaborator

hffvld commented Nov 21, 2024

Verified on MacBook Pro using version(s):

Device/OS: MacBook Pro / 15.1.1 (24B91)
Brave build: 1.75.41
Chromium: 131.0.6778.85 (Official Build) nightly (arm64)

STEPS:

  1. Launch Brave
  2. Open Leo
  3. Tap [/] to open slash tools > Verify
  4. Select Change tone > Academic, for example, and type a query
  5. Wait for the response > Verify

ACTUAL RESULTS:

  • Verified that the slash tools menu can be opened.
  • Verified that the slash tools can be used when sending a query to Leo.
1 2
1 2

kjozwiak pushed a commit that referenced this pull request Nov 22, 2024
@petemill
[Uplift 1.74] AI Chat: fix action menu (#26555) (#26669)
dcf0e5c 
AI Chat: fix action menu (#26555)

Resolves brave/brave-browser#41635
Resolves brave/brave-browser#42279
kjozwiak pushed a commit that referenced this pull request Nov 22, 2024
@petemill
[Uplift 1.73] AI Chat: fix action menu (#26555) (#26670)
fcc7871 
AI Chat: fix action menu (#26555)

Resolves brave/brave-browser#41635
Resolves brave/brave-browser#42279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

Assignees

@petemill petemill

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.75.x - Nightly
Development

Successfully merging this pull request may close these issues.

Slash tools not working for Leo
5 participants
@petemill @brave-builds @hffvld @fallaciousreasoning @SergeyZhukovsky