Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix URL-Bar LTR-RTL Clipping #26360

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Nov 4, 2024

Resolves brave/brave-browser#42070 and https://github.com/brave/internal/issues/1228

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 4, 2024
@Brandon-T Brandon-T self-assigned this Nov 4, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner November 4, 2024 19:18
Comment on lines 73 to 74
.environment(\.layoutDirection, .leftToRight)
.flipsForRightToLeftLayoutDirection(false)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are better put in URLElidedText directly since you'd probably want it anywhere its used

Copy link
Contributor Author

@Brandon-T Brandon-T Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Fixed.

Comment on lines 579 to 580
textSize = attributedText?.size() ?? .zero
textSize = (text as? NSString)?.size(withAttributes: [.font: font!]) ?? .zero
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you setting this twice?

@@ -407,6 +407,92 @@ extension URL {

return proposedPath
}

public var isLTRRendered: Bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place in BraveShared, not Shared (reminder: Shared is a legacy Firefox target we're trying to avoid adding new things to)

)

// Strip prefixes
if let range = renderedString.range(of: "^(www|mobile|m)\\.", options: .regularExpression) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't omitTrivialSubdomains above do the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http scheme is shown in the URL bar when visiting insecure sites
3 participants