Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrast improvement for pinned tabs #26259

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

aguscruiz
Copy link
Collaborator

Resolves brave/brave-browser#41720

Current pinned tabs outline color:

image image

New pinned tabs outline color:

image image

Current active state for tabs (release):

image

New active state for tabs:

image

Current active state for tabs (release - not visible):

image

New hover state for tabs:

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aguscruiz aguscruiz merged commit 83e94f4 into master Oct 28, 2024
18 checks passed
@aguscruiz aguscruiz deleted the desktop-contrast-theme branch October 28, 2024 19:21
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 28, 2024
brave-builds added a commit that referenced this pull request Oct 28, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.54

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 29, 2024

Verification PASSED using

Brave | 1.73.55 Chromium: 131.0.6778.14 (Official Build) nightly (64-bit)
-- | --
Revision | e0947f10f36b99fee562e78bd6a8116926c0ba89
OS | Windows 11 Version 23H2 (Build 22631.4391)
Pinned tabs - Horizontal tabs - PASSED

Light theme

1.71.118 1.73.55
image image

Dark theme

1.71.118 1.73.55
image image
Pinned tabs - Vertical tabs - PASSED

Dark theme

1.71.118 1.73.55
image image

Light theme

1.71.118 1.73.55
image image
Current active tab - Horizontal tabs - PASSED

Dark theme

1.71.118 1.73.55
image image

Light theme

1.71.118 1.73.55
image image
Current active tab - Vertical tabs - PASSED

Light theme

1.71.118 1.73.55
image image

Dark theme

1.71.118 1.73.55
image image
Hover state for tabs - Horizontal - PASSED

Light theme

1.71.118 1.73.55
image image

Dark theme

1.71.118 1.73.55
image image
Hover state for tabs - Vertical tabs - PASSED

Dark theme

1.71.118 1.73.55
image image

Light theme

1.71.118 1.73.55
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned tabs in vertical view are not visually separated from non-pinned tabs
5 participants