Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Fixes System Notification ad is clicked and dismissed at the same time on Linux #26251

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Oct 25, 2024

Resolves brave/brave-browser#41101

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Start browser with the fresh profile on Linux
  • Join Brave Rewards
  • Trigger a system/native notification ad
  • Click the notification ad

EXPECTATION:

  • Notification ad clicked event is triggered. There should be logs entry:
    Clicked notification ad with placement id %%% and creative instance id %%%
  • Notification ad dismissed event is NOT triggered. There should NOT log entry:
    Dismissed notification ad with placement id %%% and creative instance id %%%

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@aseren aseren enabled auto-merge October 26, 2024 01:37
@aseren aseren merged commit 25a2f70 into master Oct 26, 2024
19 checks passed
@aseren aseren deleted the issues/41101 branch October 26, 2024 02:35
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 26, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.51

@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Notification ad is clicked and dismissed at the same time
4 participants