Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for rerun compare chromium versions (1.71.x) #26240

Merged

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Oct 25, 2024

Uplift of #26230

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik added CI/skip Do not run CI builds (except noplatform) QA/No CI/skip-teamcity Do not run builds in TeamCity labels Oct 25, 2024
@wknapik wknapik self-assigned this Oct 25, 2024
@wknapik wknapik requested a review from a team as a code owner October 25, 2024 16:46
@kjozwiak kjozwiak added this to the 1.71.x - Release #3 milestone Oct 25, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.71.x approved 👍

@kjozwiak kjozwiak merged commit fab758f into 1.71.x Oct 25, 2024
12 of 13 checks passed
@kjozwiak kjozwiak deleted the wknapik-workaround-for-rerun-compare-chromium-versions-1.71.x branch October 25, 2024 16:52
@brave-builds
Copy link
Collaborator

Released in v1.71.120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) CI/skip-teamcity Do not run builds in TeamCity QA/No
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants