Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server selection settings option UI #26238

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Oct 25, 2024

Resolves brave/brave-browser#41894

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please follow the issue

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 25, 2024
@deeppandya deeppandya added this to the 1.73.x - Nightly milestone Oct 25, 2024
@deeppandya deeppandya self-assigned this Oct 25, 2024
@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 25, 2024
@deeppandya deeppandya force-pushed the update_server_selection_settings_option_ui branch from 11cc7da to 7980b55 Compare October 25, 2024 16:28
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 25, 2024
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit 6aaf5ff into master Oct 25, 2024
17 checks passed
@deeppandya deeppandya deleted the update_server_selection_settings_option_ui branch October 25, 2024 18:11
brave-builds added a commit that referenced this pull request Oct 25, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.50

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.73.50 Chromium: 131.0.6778.14 (Official Build) canary (64-bit)
--- | ---
Revision | 9ff1ef4c3f5d6e057e76e81308a8f6e8aac92f9e
OS | Android 15; Build/AP41.240823.009; 35; REL

Using the STR/Cases outlined via brave/brave-browser#41894 (comment), ensured that the server is being displayed via VPN Settings when Optimal is being selected as per the following:

Example Example Example
Screenshot_20241025-234808 Screenshot_20241025-234837 Screenshot_20241025-234901

kjozwiak pushed a commit that referenced this pull request Oct 26, 2024
@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update server selection option in settings
6 participants