-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return IDS_WALLET_INVALID_PARAMETERS if duplicate NFT IDs are passed to JsonRpcService::GetNftMetadatas #26171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
reviewed
Oct 24, 2024
for (const auto& nft : nft_identifiers) { | ||
// Create a unique string identifier combining contract, token id, and chain | ||
std::string unique_id = | ||
nft->contract_address + "_" + nft->token_id + "_" + nft->chain_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base::StrCat
yrliou
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with one minor comment above
github-actions
bot
added
the
chromium-version-mismatch
The Chromium version on the PR branch does not match the version on the target branch
label
Oct 28, 2024
…to JsonRpcService::GetNftMetadatas
nvonpentz
force-pushed
the
nft-metadata-api-fix
branch
from
October 28, 2024 14:25
6434ed0
to
90695ca
Compare
github-actions
bot
removed
the
chromium-version-mismatch
The Chromium version on the PR branch does not match the version on the target branch
label
Oct 28, 2024
Released in v1.73.54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#41829
iOS side fix to stop sending duplicate NFT IDs #26174
cc @nuo-xu
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: