Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKU SDK: use new item / request specific credential APIs (uplift to 1.62.x) #21571

Merged
merged 2 commits into from
Jan 17, 2024
Merged

SKU SDK: use new item / request specific credential APIs (uplift to 1.62.x) #21571

merged 2 commits into from
Jan 17, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 12, 2024 •
edited by kjozwiak
Loading

Uplift of #20820
Resolves brave/brave-browser#34069

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 12, 2024 22:47
@brave-builds brave-builds requested a review from a team January 12, 2024 22:47
@brave-builds brave-builds added this to the 1.62.x - Beta milestone Jan 12, 2024
@brave-builds brave-builds self-assigned this Jan 12, 2024
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 12, 2024
@evq evq force-pushed the pr20820_sku-credentials-by-request-id_1.62.x branch from de4fdbc to 746b7ab Compare January 16, 2024 22:58
kjozwiak
kjozwiak approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evq verified that the above changes were working as expected via 1.63.x. QA will run through the PR/changes once we get 1.62.x build with the above changes.

@kjozwiak kjozwiak merged commit fb5d5d9 into 1.62.x Jan 17, 2024
13 checks passed
@kjozwiak kjozwiak deleted the pr20820_sku-credentials-by-request-id_1.62.x branch January 17, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @evq