Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup bootstrap (uplift to 1.62.x) #21563

Merged
merged 2 commits into from
Jan 12, 2024
Merged

cleanup bootstrap (uplift to 1.62.x) #21563

merged 2 commits into from
Jan 12, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Jan 12, 2024 •
edited by kjozwiak
Loading

Uplift of #17179
Fixes brave/brave-browser#35184

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@goodov goodov requested a review from a team as a code owner January 12, 2024 12:12
@goodov goodov added this to the 1.62.x - Beta milestone Jan 12, 2024
@goodov goodov self-assigned this Jan 12, 2024
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 12, 2024
kjozwiak
kjozwiak approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍

@kjozwiak kjozwiak merged commit f4fd385 into 1.62.x Jan 12, 2024
13 checks passed
@kjozwiak kjozwiak deleted the pr17179_cleanup-boostrap_1.62.x branch January 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@goodov goodov

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@goodov @kjozwiak