aichat: model maker text shouldnt look like a link #21220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
nullhook
force-pushed
the
ai-chat-model-maker
branch
from
ef92713
to
110be7f
Compare
|
A Storybook has been deployed to preview UI for the latest push |
nullhook
force-pushed
the
ai-chat-model-maker
branch
from
110be7f
to
0d2f43d
Compare
petemill
approved these changes
Dec 14, 2023
| @@ -39,12 +39,12 @@ export default function ModelIntro () { | |||
| <Icon name='product-brave-leo' /> | |||
| </div> | |||
| <div className={styles.meta}> | |||
| <h2 className={styles.category}>{getCategoryName(model.category)}</h2> | |||
| <h4 className={styles.category}>{getCategoryName(model.category)}</h4> | |||
There was a problem hiding this comment.
nit: This change is largely inconsequential, so it's fine - but IMO the element header tag doesn't need to match the font-size variable name since the hierarchy should make sense per-page rather than the design system overall, but that's a debate that css devs have had for many years!
|
A Storybook has been deployed to preview UI for the latest push |
nullhook
force-pushed
the
ai-chat-model-maker
branch
from
0d2f43d
to
db87a28
Compare
|
A Storybook has been deployed to preview UI for the latest push |
nullhook
added a commit
that referenced
this pull request
Jan 18, 2024
kjozwiak
pushed a commit
that referenced
this pull request
Jan 19, 2024
24 tasks
kjozwiak
pushed a commit
that referenced
this pull request
Jan 20, 2024
* Merge pull request #21134 from brave/cr121 Upgrade from Chromium 120 to Chromium 121. * Remove the assert for patch_ffmpeg.py (#21184) * Merge pull request #21539 from brave/ffmpeg-dynamic-alloc Use dynamic allocation for ffmpeg fft tables on Windows. * Merge pull request #21585 from brave/issues/35318 Remove dynamic allocation of ffmpeg ff_tx tables. * Disables a flaky upstream browser test. * Merge pull request #21584 from brave/fix_new_tab_button_plus_misaligned Fixed new tab button's plus icon is mis-aligned with horizontal tab * Merge pull request #21600 from brave/121.0.6167.75_master Upgrade from Chromium 121.0.6167.57 to Chromium 121.0.6167.75. * Merge pull request #21628 from brave/maxk-disable-reading-mode Hides `Open in Reading Mode` context menu item. * [Uplift 1.62.x] AI chat issues cr121 1.62.x (#21629) * aichat: input is growable (#21124) * aichat: scroll is interruptable (#21235) * aichat: model maker text shouldnt look like a link (#21220) * aichat: code formatting (#21342) * make claude output formatted code (#21599) --------- Co-authored-by: Mikhail <[email protected]> Co-authored-by: Aleksey Khoroshilov <[email protected]> Co-authored-by: Simon Hong <[email protected]> Co-authored-by: taher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#34258
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: