Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt non-GET requests from the query filter #15706

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Oct 29, 2022

Resolves brave/brave-browser#26377

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Use the last section (POST tests) on https://fmarier.github.io/brave-testing/query-filter.html

@fmarier fmarier requested a review from iefremov as a code owner October 29, 2022 00:31
@fmarier fmarier self-assigned this Oct 29, 2022
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Oct 29, 2022
@fmarier fmarier force-pushed the query-filter-non-get-26377 branch from 0619398 to f7e0a03 Compare October 29, 2022 04:20
@fmarier fmarier added this to the 1.47.x - Nightly milestone Oct 29, 2022
@fmarier fmarier merged commit eafb598 into master Oct 31, 2022
@fmarier fmarier deleted the query-filter-non-get-26377 branch October 31, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exempt non-GET requests from the query filter
3 participants