Address feedback + format

brave · Oct 25, 2024 · b1005f8 · b1005f8
1 parent 59cad1f
commit b1005f8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Menu.swift b/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Menu.swift
@@ -4,6 +4,7 @@
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 import BraveCore
+import BraveShared
 import BraveUI
 import BraveVPN
 import BraveWallet

diff --git a/...-ios/Sources/Brave/Frontend/Browser/Toolbars/BottomToolbar/Menu/History/HistoryView.swift b/...-ios/Sources/Brave/Frontend/Browser/Toolbars/BottomToolbar/Menu/History/HistoryView.swift
@@ -4,7 +4,7 @@
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 import BraveCore
-import BraveUI
+import BraveShared
 import BraveStrings
 import DesignSystem
 import Favicon
@@ -38,10 +38,12 @@ struct HistoryItemView: View {
             .fixedSize(horizontal: false, vertical: true)
             .foregroundStyle(Color(braveSystemName: .textPrimary))
         }
-
-        URLElidedText(text: URLFormatter.formatURLOrigin(
-          forDisplayOmitSchemePathAndTrivialSubdomains: url.absoluteString
-        ))
+
+        URLElidedText(
+          text: URLFormatter.formatURLOrigin(
+            forDisplayOmitSchemePathAndTrivialSubdomains: url.absoluteString
+          )
+        )
         .truncationMode(.tail)
         .font(.footnote)
         .frame(maxWidth: .infinity, alignment: .leading)

diff --git a/ios/brave-ios/Sources/Brave/Frontend/Shields/ShieldsPanelView.swift b/ios/brave-ios/Sources/Brave/Frontend/Shields/ShieldsPanelView.swift
@@ -4,6 +4,7 @@
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 import BraveCore
+import BraveShared
 import BraveShields
 import BraveUI
 import Data
@@ -82,8 +83,8 @@ struct ShieldsPanelView: View {
           isPrivateBrowsing: viewModel.isPrivateBrowsing
         )
         URLElidedText(text: displayHost)
-        .font(.title2)
-        .foregroundStyle(Color(.bravePrimary))
+          .font(.title2)
+          .foregroundStyle(Color(.bravePrimary))
       }
       .frame(minWidth: .zero, alignment: .center)
 

diff --git a/...s/BraveUI/SwiftUI/URLElidedTextView.swift → ...urces/BraveShared/URLElidedTextView.swift b/...s/BraveUI/SwiftUI/URLElidedTextView.swift → ...urces/BraveShared/URLElidedTextView.swift
@@ -24,7 +24,7 @@ public struct URLElidedText: View {
     paragraphStyle.baseWritingDirection = .leftToRight
     return paragraphStyle
   }
-  
+
   public init(text: String) {
     self.text = text
   }
@@ -36,7 +36,5 @@ public struct URLElidedText: View {
         attributes: .init([.font: font ?? .body, .paragraphStyle: paragraphStyle])
       )
     )
-    .font(font ?? .body)
-    .truncationMode(truncationMode)
   }
 }