Added verified_contents.json generator. #1008
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
boocmp
force-pushed
the
verified_contents
branch
from
8a4b099
to
7bfc65b
Compare
boocmp
force-pushed
the
verified_contents
branch
3 times, most recently
from
3ddfcb4
to
53759de
Compare
boocmp
force-pushed
the
verified_contents
branch
from
53759de
to
0fe41d2
Compare
diracdeltas
reviewed
Nov 15, 2024
| const generateComponentMetadata = ( | ||
| inputDir, | ||
| publisherProofKey, | ||
| publisherProofKeyAlt |
There was a problem hiding this comment.
are we using the existing crx signing keys for this?
for production, is this going to be called in CI?
There was a problem hiding this comment.
I'm not sure. I am inclined to generate a new one for this purpose.
boocmp
force-pushed
the
verified_contents
branch
from
55f048b
to
05eaa62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#42274