Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/setup-node action to v4.1.0 #1002

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 30, 2024

This PR contains the following updates:

Package Type Update Change
actions/setup-node action minor v4.0.4 -> v4.1.0

Release Notes

actions/setup-node (actions/setup-node)

v4.1.0

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor

[puLL-Merge] - actions/[email protected]

Description

This PR introduces several changes to improve the caching mechanism and GHES (GitHub Enterprise Server) detection in the setup-node action. The main modifications include updating the cache key generation to include the CPU architecture, refining the GHES detection logic, and updating dependencies.

Changes

Changes

  1. .github/workflows/publish-immutable-actions.yml:

    • Updated the trigger event from created to published for releases.
    • Changed the publish action version from 0.0.1 to 0.0.3.
    • Removed explicit GitHub token input.
  2. __tests__/cache-restore.test.ts:

    • Added os module import and mocking of os.arch() function.
    • Updated test cases to include CPU architecture in cache key generation.
  3. __tests__/cache-utils.test.ts:

    • Added new test cases for the isGhes() function to cover various scenarios.
  4. __tests__/data/pnpm-lock.yaml:

    • Updated lockfile version and dependencies.
  5. dist/cache-save/index.js and dist/setup/index.js:

    • Updated the isGhes() function implementation to handle more edge cases.
    • Modified cache key generation to include CPU architecture.
  6. src/cache-restore.ts:

    • Added CPU architecture to the cache key generation.
  7. src/cache-utils.ts:

    • Refined the isGhes() function to better detect GitHub Enterprise Server instances.

Possible Issues

  • The changes to the cache key generation (including CPU architecture) may result in cache misses for existing caches. Users might need to rebuild their caches after this update.

Security Hotspots

No significant security issues were identified in this PR.

@mihaiplesa mihaiplesa merged commit b25d8a5 into master Oct 30, 2024
10 checks passed
@mihaiplesa mihaiplesa deleted the renovate/actions-setup-node-4.x branch October 30, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant