-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop Release Notes for 1.41.x Release #24014
Conversation
@@ -1,5 +1,39 @@ | |||
# Changelog | |||
|
|||
## [1.41.96](https://github.com/brave/brave-browser/releases/tag/v1.41.96) | |||
|
|||
- Added Solana Dapp support for Brave Wallet. ([#23520](https://github.com/brave/brave-browser/issues/23520)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit. Should be DApp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been using Dapp
since the beginning as per https://raw.githubusercontent.com/brave/brave-browser/master/CHANGELOG_DESKTOP.md. If that's the case, we'll need to change all instances of Dapp
-> DApp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed, will change in a follow up 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
++ Looks good. |
Fix #23980
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
n/a