Migrate kUnstoppableDomains and a few other string arrays to proper containers
#42484
Comments
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 23, 2024
This PR changes a few places where we used to have we had something like: ```cxx constexpr const char* kConstant[] = ... ``` These arrays array are not as safe as proper containers. There's also the challange that the strings referred by these arrays cannot have their sizes encoded on the type, so there's a certain reliance on `strlen` to determine the size. This change converts on of these arrays to `std::array`. The other array was converted to a `constexpr` flat set, as that is what this array was being used for. This flat set requires a custom comparator though, as the search of the elements as matching against `end_with`. With this change, the lookup will be a bit less wasteful. Resolves brave/brave-browser#42484
24 tasks
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 23, 2024
This PR changes a few places where we used to have we had something like: ```cxx constexpr const char* kConstant[] = ... ``` These arrays array are not as safe as proper containers. There's also the challange that the strings referred by these arrays cannot have their sizes encoded on the type, so there's a certain reliance on `strlen` to determine the size. This change converts on of these arrays to `std::array`. The other array was converted to a `constexpr` flat set, as that is what this array was being used for. This flat set requires a custom comparator though, as the search of the elements as matching against `end_with`. With this change, the lookup will be a bit less wasteful. Resolves brave/brave-browser#42484
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 24, 2024
This PR changes a few places where we used to have we had something like: ```cxx constexpr const char* kConstant[] = ... ``` These arrays array are not as safe as proper containers. There's also the challange that the strings referred by these arrays cannot have their sizes encoded on the type, so there's a certain reliance on `strlen` to determine the size. This change converts on of these arrays to `std::array`. The other array was converted to a `constexpr` flat set, as that is what this array was being used for. This flat set requires a custom comparator though, as the search of the elements as matching against `end_with`. With this change, the lookup will be a bit less wasteful. Resolves brave/brave-browser#42484
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 25, 2024
This PR changes a few places where we used to have we had something like: ```cxx constexpr const char* kConstant[] = ... ``` These arrays array are not as safe as proper containers. There's also the challange that the strings referred by these arrays cannot have their sizes encoded on the type, so there's a certain reliance on `strlen` to determine the size. This change converts on of these arrays to `std::array`. The other array was converted to a `constexpr` flat set, as that is what this array was being used for. This flat set requires a custom comparator though, as the search of the elements as matching against `end_with`. With this change, the lookup will be a bit less wasteful. Resolves brave/brave-browser#42484
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 25, 2024
This PR changes a few places where we used to have we had something like: ```cxx constexpr const char* kConstant[] = ... ``` These arrays array are not as safe as proper containers. There's also the challange that the strings referred by these arrays cannot have their sizes encoded on the type, so there's a certain reliance on `strlen` to determine the size. This change converts on of these arrays to `std::array`. The other array was converted to a `constexpr` flat set, as that is what this array was being used for. This flat set requires a custom comparator though, as the search of the elements as matching against `end_with`. With this change, the lookup will be a bit less wasteful. Resolves brave/brave-browser#42484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
These are the few remaining cases of array of strings that can be modernised.
The text was updated successfully, but these errors were encountered: