Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic cosmetic filter list rules are not applied on some sites #42471

Closed
StephenHeaps opened this issue Nov 23, 2024 · 2 comments · Fixed by brave/brave-core#26729
Closed

Generic cosmetic filter list rules are not applied on some sites #42471

StephenHeaps opened this issue Nov 23, 2024 · 2 comments · Fixed by brave/brave-core#26729
Assignees
@StephenHeaps
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/iOS Fixes related to iOS browser functionality privacy QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.73.x - Release #3

Comments

@StephenHeaps
Copy link

StephenHeaps commented Nov 23, 2024 •
edited
Loading

Description

Generic cosmetic filter list rules are not applied on some sites

Steps to Reproduce

  1. Add custom filter rules:
##.cc-bottom.cc-floating.cc-window
##div.cc-revoke
  1. Visit https://laurentferrier.ch/products/classic-auto-sandstone?variant=44866903605410
  2. Observe cookie banner is visible
  3. Visit https://www.chefs-edge.com/collections/whetstones/products/shapton-rockstar-whetstone-1000-grit
  4. Observe cookie banner is visible
  5. Visit https://goldammer.me/collections/all
  6. Observe cookie banner is visible
@StephenHeaps StephenHeaps added feature/shields/adblock Blocking ads & trackers with Shields OS/iOS Fixes related to iOS browser functionality privacy labels Nov 23, 2024
@StephenHeaps StephenHeaps self-assigned this Nov 23, 2024
@StephenHeaps StephenHeaps mentioned this issue Nov 25, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 25, 2024
This was referenced Nov 25, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.73.94 or higher for 1.73.x verification 👍

@kjozwiak kjozwiak mentioned this issue Nov 26, 2024
Open
15 tasks
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 27, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18 using version 1.73 (94)

custom filter rules:

##.cc-bottom.cc-floating.cc-window
##div.cc-revoke
Rules Laurentferrier Chefs-edge Goldammer Goldammer product
Image Image Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/iOS Fixes related to iOS browser functionality privacy QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.73.x - Release #3
4 participants
@kjozwiak @StephenHeaps @Uni-verse @brave-builds