Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Playlist audio stops and starts momentarily when locking/unlocking the device #42468

Closed
2 of 5 tasks
kylehickinson opened this issue Nov 22, 2024 · 2 comments · Fixed by brave/brave-core#26704
Closed
2 of 5 tasks

New Playlist audio stops and starts momentarily when locking/unlocking the device #42468

kylehickinson opened this issue Nov 22, 2024 · 2 comments · Fixed by brave/brave-core#26704
Assignees
@kylehickinson
Labels
features/playlist OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.73.x - Release #3

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Nov 22, 2024 •
edited
Loading

Description

Some users are reporting an annoyance when locking/unlocking their devices with an item playing where the audio stops/starts momentarily

Steps to reproduce

  1. Open Playlist and start playing an item
  2. Lock the device then subsequently unlock the device

Actual result

After locking and unlocking the audio stops and resumes quickly

Expected result

Should transition smoothly between background + foreground without stopping

Reproduces how often

Easily reproduced

Brave version

1.71+

Device/iOS version

N/A

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@kylehickinson kylehickinson self-assigned this Nov 22, 2024
@kylehickinson kylehickinson mentioned this issue Nov 22, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 23, 2024
This was referenced Nov 23, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.73.93 or higher for 1.73.x verification 👍

@kjozwiak kjozwiak mentioned this issue Nov 25, 2024
Open
15 tasks
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18 using version 1.73 (93)

  • Ensured audio is not disrupted or pauses when locking/unlocking the device.
playlist lockscreen
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
features/playlist OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.73.x - Release #3
Development

Successfully merging a pull request may close this issue.

[iOS] Remove video ambiance decoration in new Playlist UI brave/brave-core
4 participants
@kylehickinson @kjozwiak @Uni-verse @brave-builds