Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model maker shouldn't look like a link #34258

Closed
bbondy opened this issue Nov 10, 2023 · 6 comments · Fixed by brave/brave-core#21220
Closed

Model maker shouldn't look like a link #34258

bbondy opened this issue Nov 10, 2023 · 6 comments · Fixed by brave/brave-core#21220

Comments

@bbondy
Copy link
Member

bbondy commented Nov 10, 2023

I think this is just removing the bold on Meta in "llama2 13b by Meta"?
Screenshot 2023-11-15 at 4 28 59 PM

@bbondy bbondy converted this from a draft issue Nov 10, 2023
@aguscruiz
Copy link

aguscruiz commented Nov 16, 2023

Also use the same color as the other intro text.
Design here:
https://www.figma.com/file/MNwi0uwXNhkAbPiJ86G4vm/%F0%9F%A7%A0-Leo?type=design&node-id=1506%3A8040&mode=design&t=upvAdyiJo5OuDjpE-1

image

@nullhook nullhook self-assigned this Dec 4, 2023
@nullhook nullhook moved this from Important / Polish to In Progress in Browser AI Dec 4, 2023
@nullhook nullhook moved this from In Progress to In Review in Browser AI Dec 4, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Dec 15, 2023
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 15, 2023
@stephendonner
Copy link

stephendonner commented Dec 19, 2023

Verified PASSED using

Brave | 1.63.51 Chromium: 120.0.6099.115 (Official Build) nightly (64-bit)
-- | --
Revision | d4b258be9973bf7f91ae4f1c7ca2eea5c2882085
OS | Windows 10 Version 22H2 (Build 19045.3803)

Steps:

  1. installed 1.63.51
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. purchased and loaded AI-chat Premium Leo credentials from `account.bravesoftware.com
  4. clicked on Leo in the sidebar
  5. asked Leo a question
  6. clicked on Accept and begin
  7. noted the byline for llama2-13b
  8. switched LLM via the ... ellipsis on the top right of the AI panel
  9. noted the bylines for llama2-70b and Claude Instant

Confirmed the Meta in [llm-name] by Meta is no longer bolded, and is the same color and font weight as the rest of its byline text

llama2-13b llama2-70b Claude Instant
image image image

@LaurenWags
Copy link
Member

@nullhook @bbondy @rebron could someone please add the appropriate release notes label for this one?

@kjozwiak
Copy link
Member

Removing QA Pass labels as the above will need to be re-checked using 1.62.x. However, used #34258 (comment) as the needed verification to get the above uplifted into 1.62.x.

Adding QA/Blocked for now as the above was merged into cr121-1.62.x via brave/brave-core#21593. Once C121 is merged into 1.62.x via brave/brave-core#21593, we'll unblock the above and mention the needed 1.62.x version for verification 👍

@kjozwiak
Copy link
Member

The above requires 1.62.148 or higher for 1.62.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (x86_64)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | macOS Version 11.7.10 (Build 20G1427)
Mixtral Claude Instant Llama2-13b
Screen Shot 2024-01-22 at 1 16 18 PM Screen Shot 2024-01-22 at 1 17 19 PM Screen Shot 2024-01-22 at 1 17 33 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment