Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Music has improper font spacing #22605

Closed
pilgrim-brave opened this issue Apr 28, 2022 · 6 comments · Fixed by brave/brave-core#13205
Closed

Apple Music has improper font spacing #22605

pilgrim-brave opened this issue Apr 28, 2022 · 6 comments · Fixed by brave/brave-core#13205

Comments

@pilgrim-brave
Copy link

image

@pilgrim-brave
Copy link
Author

Turning off font whitelisting fixes it

@stephendonner
Copy link

stephendonner commented May 27, 2022

@pilgrim-brave do you have a test plan you could attach, and/or expected-results screenshot? Were you logged in or out (or does it matter?) Thanks!

1.40.77 looks correct to me, but wanted to double-check.

Brave 1.40.77 Chromium: 102.0.5005.61 (Official Build) beta (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

So far, I've:

  1. installed 1.40.77
  2. launched Brave
  3. loaded https://music.apple.com/us/album/the-baby-teeth-album/64868585
  4. compared layout to 1.39.111
1.39.111 1.40.77
Screen Shot 2022-05-27 at 4 06 54 PM Screen Shot 2022-05-27 at 4 12 59 PM

@pilgrim-brave
Copy link
Author

Yes, that exactly shows the issue (being fixed). No further test plan required.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 2, 2022

Removed QA Pass-macOS as this was uplifted into 1.39.x as per brave/brave-core#13550 and will need to be rechecked using 1.39.x once we get the correct RC builds. Used the verification outlined via #22605 (comment) for the uplift as per brave/brave-core#13550 (review).

@stephendonner
Copy link

stephendonner commented Jun 3, 2022

Verified PASSED using

Brave 1.39.117 Chromium: 102.0.5005.78 (Official Build) (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 11.6.6 (Build 20G624)

Steps:

  1. installed 1.39.117
  2. launched Brave
  3. loaded https://music.apple.com/us/album/the-baby-teeth-album/64868585
  4. checked both Light and Dark modes

Confirmed font-spacing/layout is correct.

Light Dark
Screen Shot 2022-06-03 at 9 28 14 AM Screen Shot 2022-06-03 at 9 28 27 AM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 3, 2022

Verification PASSED using

Brave | 1.39.117 Chromium: 102.0.5005.78 (Official Build) (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 11 Version 21H2 (Build 22000.675)

Followed above test plan by @stephendonner

1.39.111 1.39.117
image1 image1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment