Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Implement "reduce language fingerprinting" and follow ups #13903

Closed
wants to merge 2 commits into from

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jun 22, 2022

Revert Implement "reduce language fingerprinting" and follow ups
Fixes brave/brave-browser#23093

Reopens brave/brave-browser#20096
Reopens brave/brave-browser#816


Reverts #12952
Which fixed brave/brave-browser#22177

Reverts #12942
Which fixed brave/brave-browser#21985

Reverts #13807
Which fixed brave/brave-browser#23489

Reverts #13205
Which fixed brave/brave-browser#22605

Reverts #12234
Which fixed brave/brave-browser#20096 and brave/brave-browser#816

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used GitHub auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Visit brave://settings/shields
  2. Verify the setting Prevent sites from fingerprinting me based on my language preferences was removed (if present, it would be above Trackers & ads blocking)
  3. Try out some of the sites called out in Shields breaking text/fonts on some websites brave-browser#23093 and make sure font looks correct

@bsclifton bsclifton requested review from a team as code owners June 22, 2022 16:40
@bsclifton bsclifton self-assigned this Jun 22, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Jun 22, 2022
@bsclifton bsclifton changed the title Bsc revert font fingerprint Revert Implement "reduce language fingerprinting" and follow ups Jun 22, 2022
@bsclifton
Copy link
Member Author

bsclifton commented Jun 22, 2022

Closing - we're going to solve by disabling by default (see #13905) and then using Griffin to roll out. Griffin is where the fix will happen for users (it'll be disabled there for 100% of users)

Staging rollout to 100% was done with brave/brave-variations#291 - production coming soon.

@bsclifton bsclifton closed this Jun 22, 2022
@bsclifton bsclifton deleted the bsc-revert-font-fingerprint branch June 22, 2022 19:26
@github-actions github-actions bot added this to the 1.42.x - Nightly milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
1 participant