Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields v2 broken for IPFS/IPNS schemes #22496

Closed
stephendonner opened this issue Apr 22, 2022 · 4 comments
Closed

Shields v2 broken for IPFS/IPNS schemes #22496

stephendonner opened this issue Apr 22, 2022 · 4 comments
Labels
bug closed/wontfix feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No QA/Test-Plan-Specified regression release-notes/exclude

Comments

@stephendonner
Copy link

stephendonner commented Apr 22, 2022

Description

Shields broken for IPNS schemes

Steps to Reproduce

  1. install 1.39.73
  2. launch Brave
  3. load ipns://ipfs.io
  4. click on Use a Brave local IPFS node
  5. click on the Shields icon in the URL bar

Actual result:

Toggle Shields; nothing happens.

Screen Shot 2022-04-22 at 12 23 20 AM

Expected result:

Shields should either work or be disabled.

Screen Shot 2022-04-22 at 12 25 29 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.40.4 Chromium: 101.0.4951.41 (Official Build) nightly (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 12.4 (Build 21F5058e)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NO
  • Can you reproduce this issue with the beta channel? YES
  • Can you reproduce this issue with the nightly channel? YES

cc @spylogsster @nullhook @MadhaviSeelam @GeetaSarvadnya @rebron @kjozwiak

@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. feature/global-settings Settings at browser level independent of shields settings QA/Yes QA/Test-Plan-Specified feature/web3/ipfs regression OS/Desktop labels Apr 22, 2022
@stephendonner
Copy link
Author

Note that this works for http://docs.ipfs.io.ipns.localhost:48081/concepts/content-addressing/:

Screen Shot 2022-04-22 at 1 33 50 AM

@stephendonner
Copy link
Author

stephendonner commented Apr 23, 2022

also cc @lidel @autonome (just as FYI)

@rebron rebron mentioned this issue Apr 25, 2022
7 tasks
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 29, 2022
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P4 Backlog in General May 28, 2024
@vadimstruts
Copy link
Collaborator

The IPFS local node and scheme has been deprecated

@github-project-automation github-project-automation bot moved this from P4 Backlog to Completed in General Sep 2, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Sep 3, 2024

The IPFS local node and scheme has been deprecated

Going to move this into https://github.com/brave/brave-browser/milestone/497 as per the above.

@kjozwiak kjozwiak added this to the 1.69.x - Release milestone Sep 3, 2024
@rebron rebron removed this from General Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/wontfix feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No QA/Test-Plan-Specified regression release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants