Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Shields UI for non-http(s) protocols #24984

Open
rebron opened this issue Aug 25, 2022 · 2 comments
Open

update Shields UI for non-http(s) protocols #24984

rebron opened this issue Aug 25, 2022 · 2 comments
Assignees
Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 25, 2022

Description

The shields UI is currently confusing and misleading when viewing non HTTP(s) sites (e.g., blob://, file://, ipfs://, brave://, etc).

Here is a (possibly incomplete) list of issues with the current implementation:

  • The lion icon in the URL bar appears disabled, regardless of whether protections are being applied
  • You can toggle shields to enabled, but it doesn’t stick (it stays appearing disabled) for some protocols
  • Toggling shields to enabled / disabled doesn’t actually change the protections applied to the page.
  • Different policies are applied to different protocols, though there is no UI or notification to the user of what protections are applied (or if / how they can be changed)

Expected result:

Figma file: https://www.figma.com/file/3A6F6VrxVahiZFxLr7j7FO/Desktop-Shields?node-id=2394%3A33182

  1. Update shields UI for non-http(s) protocols
  • Should not have an on/off toggle
  • Should inform the user that the global settings are being used
  • Should show the user the global settings, read-only
  • Should link to brave://settings/shields so users can change the global settings if desired
  • Should have a “disabled” view too, in case the user has globally disabled shields
  • Open item/follow-up issue whether to display a title in the shields UI where we currently show the origin since some protocols there will be no origin. In others such as IPFS, there will be an origin. When an origin isn't present, display the protocol the page is fetched over.
  1. For brave://, chrome://, chrome-extension://, top-level about://, and other trusted Chrome protocols
  • Do not show the shields UI in the URL bar
  • Do not apply any shields protections
  1. For all other non http(s):// sites
  • Apply the global shields settings to the page
  • Presents users the UI in item 1 above
  1. No changes to how shields is applied to http(s):// pages

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issue: #22496
Spec: https://docs.google.com/document/d/1NMOylklswutemt7P-2CHIdp1dF2S93ONP9u8dZp7Hhk/edit#

@rebron rebron added OS/Desktop feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 25, 2022
@rebron
Copy link
Collaborator Author

rebron commented Aug 25, 2022

cc: @pes10k @diracdeltas

@pes10k
Copy link
Contributor

pes10k commented Aug 25, 2022

Thanks @rebron this will be a terrific update, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

3 participants