Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Brave design system components to Shields #16654

Closed
Tracked by #18630
rebron opened this issue Jun 28, 2021 · 2 comments
Closed
Tracked by #18630

Apply Brave design system components to Shields #16654

rebron opened this issue Jun 28, 2021 · 2 comments
Assignees
Labels
closed/duplicate Issue has already been reported OS/Desktop

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 28, 2021

Description

Apply design system components to Shields to improve accessibility, contrast, and usability.

Design

Shields panel

image

The Brave design system components being applied are:

Also, the toggle should have a gradient transition effect similar to the one implemented on mobile:

fabtoggle

You can reference this iOS issue: brave/brave-ios#1923 Kyle and Michal on the iOS team built it.

it's a loop with 2ms between each color state + easy ease:
linear-gradient(120deg, rgba(255,167,59,1) 0%, rgba(255,118,84,1) 100%);
linear-gradient(120deg, rgba(255,118,84,1) 0%, rgba(251,84,43,1) 100%);
linear-gradient(120deg, rgba(251,84,43,1) 0%, rgba(247,36,28,1) 100%);
linear-gradient(120deg, rgba(247,36,28,1) 0%, rgba(252,79,130,1) 100%);
linear-gradient(120deg, rgba(252,79,130,1) 0%, rgba(255,167,59,1) 100%);
linear-gradient(120deg, rgba(255,167,59,1) 0%, rgba(255,118,84,1) 100%);
#FFA73B ➡️ #FF7654 ➡️ #FB542B ➡️ #F7241C ➡️ #FC4F82 ➡️ #FFA73B

Removing the Simple/Advanced view

The "Advanced controls" accordion element in the Shields panel would replace the current Simple/Advanced view - accordion closed is "simple view" (default) and accordion open is the "advanced view". The accordion will remember its open/closed position and display as open/closed globally depending on how the user left it, the same as current simple/advanced view setting. It will make the advanced controls feel a bit easier to get to since it's not a separate "view", but rather just collapsed.

Another benefit of this accordion design is that we can get rid of the "default view" setting in brave://settings/shields

image

We can also remove the "Advanced view" disclaimer popup since the disclaimer text is embedded in the Advanced area of Shields.

image

Copy updates

Simple / advanced view:

  • "If a site appears broken, try Shields down." → "If this site seems broken, try Shields down. Note: this may reduce Brave privacy protections."

Report a broken site:

  • "You're browsing this site without Brave's privacy protections. Does it not work right with Shields up?" → "You're viewing this site without Brave's privacy protections. Does it seem broken with Shields up?"
  • [button] "Report a broken site" → "Report site broken"
  • "Let Brave's developers know that this site doesn't work properly with Shields:" → "Let Brave know that this site seems broken with Shields up:"
  • "Note: This site address will be submitted with your Brave version number and your IP address (which will not be stored)." → "Note: Clicking "Submit" will share the site address, your Brave version number, and your IP address with Brave. Your IP address will not be stored."
  • "Thanks for letting Brave's developers know that there's something wrong with this site. We'll do our best to fix it." → "Thanks for letting us know about this broken site. We'll do our best to fix it! Please check back again soon to try the site with Shields up."

About Brave Shields:

"Sites often include cookies and scripts which try to identify you and your device. They want to work out who you are and follow you across the web — tracking what you do on every site. Brave blocks these things so that you can browse without being followed around." → "Sites often have cookies and scripts lurking in the background, trying to identify you and your device. Why? So you can be followed around the web, your activity tracked on every site you visit. Brave Shields block cookies and scripts, which means better privacy online."

Reproduces how often:

n/a

Brave version (brave://version info)

n/a

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Assets

Figma link: https://www.figma.com/file/3A6F6VrxVahiZFxLr7j7FO/Desktop-Brave-Shields?node-id=16%3A14877

Miscellaneous Information:

Related issue: #14602

@rebron rebron added feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Jun 28, 2021
@karenkliu karenkliu changed the title Apply new v2 design to Shields Apply Brave design system components to Shields Jun 28, 2021
@karenkliu
Copy link

Added relevant design details.

@rebron
Copy link
Collaborator Author

rebron commented Mar 17, 2022

Closed as dupe of #18630

@rebron rebron closed this as completed Mar 17, 2022
@rebron rebron removed feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/shields/panel Front-end design and functionality of the Shields panel. labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop
Projects
None yet
Development

No branches or pull requests

3 participants